linux-kernel - Re: [PATCH v6 06/16] x86/sev: Cache the secrets page address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAH4kHZ0fQJDiZaAhVQ31KXths5n3g1dYdfivyR-HEXcOFOY5g@mail.gmail.com>
Date:   Wed, 6 Dec 2023 14:21:33 -0800
From:   Dionna Amalie Glaze <dionnaglaze@...gle.com>
To:     Nikunj A Dadhania <nikunj@....com>
Cc:     linux-kernel@...r.kernel.org, thomas.lendacky@....com,
        x86@...nel.org, kvm@...r.kernel.org, bp@...en8.de,
        mingo@...hat.com, tglx@...utronix.de, dave.hansen@...ux.intel.com,
        pgonda@...gle.com, seanjc@...gle.com, pbonzini@...hat.com
Subject: Re: [PATCH v6 06/16] x86/sev: Cache the secrets page address

>
> +static void __init set_secrets_pa(const struct cc_blob_sev_info *cc_info)
> +{
> +       if (cc_info && cc_info->secrets_phys && cc_info->secrets_len == PAGE_SIZE)
> +               secrets_pa = cc_info->secrets_phys;
> +}

I know failure leads to an -ENODEV later on init_platform, but a
missing secrets page as a symptom seems like a good thing to log,
right?

> -       if (!gpa)
> +       if (!secrets_pa)
>                 return -ENODEV;
>


-- 
-Dionna Glaze, PhD (she/her)