linux-kernel - Re: [PATCH v6 06/16] x86/sev: Cache the secrets page address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c82cf4b8-fd4a-4288-b642-3a17e3f29579@amd.com>
Date:   Thu, 7 Dec 2023 11:36:19 +0530
From:   "Nikunj A. Dadhania" <nikunj@....com>
To:     Dionna Amalie Glaze <dionnaglaze@...gle.com>
Cc:     linux-kernel@...r.kernel.org, thomas.lendacky@....com,
        x86@...nel.org, kvm@...r.kernel.org, bp@...en8.de,
        mingo@...hat.com, tglx@...utronix.de, dave.hansen@...ux.intel.com,
        pgonda@...gle.com, seanjc@...gle.com, pbonzini@...hat.com
Subject: Re: [PATCH v6 06/16] x86/sev: Cache the secrets page address

On 12/7/2023 3:51 AM, Dionna Amalie Glaze wrote:
>>
>> +static void __init set_secrets_pa(const struct cc_blob_sev_info *cc_info)
>> +{
>> +       if (cc_info && cc_info->secrets_phys && cc_info->secrets_len == PAGE_SIZE)
>> +               secrets_pa = cc_info->secrets_phys;
>> +}
> 
> I know failure leads to an -ENODEV later on init_platform, but a
> missing secrets page as a symptom seems like a good thing to log,
> right?

Added in the next patch.

+	if (!secrets_pa) {
+		pr_err("SNP secrets page not found\n");
 		return -ENODEV;
+	}

> 
>> -       if (!gpa)
>> +       if (!secrets_pa)
>>                 return -ENODEV;
>>
> 
> 

Regards
Nikunj