linux-kernel - Re: [PATCH v1 1/1] s390: mm: convert pgste locking functions to C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXA4XkU0M1BZ5R5k@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date:   Wed, 6 Dec 2023 10:01:18 +0100
From:   Alexander Gordeev <agordeev@...ux.ibm.com>
To:     Claudio Imbrenda <imbrenda@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
        linux390-list@...maker.boeblingen.de.ibm.com,
        kvm390-list@...maker.boeblingen.de.ibm.com, hca@...ux.ibm.com,
        borntraeger@...ibm.com, frankja@...ux.ibm.com, nrb@...ux.ibm.com,
        nsg@...ux.ibm.com, svens@...ux.ibm.com, gor@...ux.ibm.com,
        gerald.schaefer@...ux.ibm.com
Subject: Re: [PATCH v1 1/1] s390: mm: convert pgste locking functions to C

On Tue, Dec 05, 2023 at 06:32:52PM +0100, Claudio Imbrenda wrote:

(Internal lists only)

...
> +	do {
> +		value = __atomic64_or_barrier(PGSTE_PCL_BIT, ptr);

Would it make sense to cpu_relax() here, e.g with a follow-up patch?

> +	} while (value & PGSTE_PCL_BIT);
> +	value |= PGSTE_PCL_BIT;
>  #endif
> -	return __pgste(new);
> +	return __pgste(value);
>  }

Thanks!