linux-kernel - Re: [PATCH] fs/namei: Don't update atime when some errors occur in get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <C295D5E9-ED04-48AD-AA4F-70803429D289@163.com>
Date:   Wed, 6 Dec 2023 17:02:18 +0800
From:   Hao Ge <gehao618@....com>
To:     Christian Brauner <brauner@...nel.org>
Cc:     Hao Ge <gehao@...inos.cn>, viro@...iv.linux.org.uk,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/namei: Don't update atime when some errors occur in get_link



> On Dec 5, 2023, at 19:07, Christian Brauner <brauner@...nel.org> wrote:
> 
> On Tue, Dec 05, 2023 at 03:17:33PM +0800, Hao Ge wrote:
>> Perhaps we have some errors occur(like security),then we don't update
>> atime,because we didn't actually access it
>> 
>> Signed-off-by: Hao Ge <gehao@...inos.cn>
>> ---
> 
> We didn't follow the link but we accessed it. I guess it's not completey
> clear what's correct here so I'd just leave it as is.
Hi brauner
Thank your for your reply.
I just thought of a situation that user access a link failed due to some error(like permission issue),maybe report some error to user, actually user don’t get anything,but atime still update.
Maybe your are right,after all,we still tried to visit.
Thanks
Best Regards 
Hao