linux-kernel - Re: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate bitmap memory in backing_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2023 18:53:12 +0900
From:   Sergey Senozhatsky <senozhatsky@...omium.org>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Dongyun Liu <dongyun.liu3@...il.com>, minchan@...nel.org,
        senozhatsky@...omium.org, axboe@...nel.dk,
        linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        lincheng.yang@...nssion.com, jiajun.ling@...nssion.com,
        ldys2014@...mail.com, Dongyun Liu <dongyun.liu@...nssion.com>
Subject: Re: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate
 bitmap memory in backing_dev_store (fwd)

Hi,

On (23/12/06 10:33), Julia Lawall wrote:
> Hello,
> 
> The warning is because kvfree is used to free memory that was allocated
> using kmalloc; kfree would be fine.  But I think that the only way you can
> get to out is with bitmap being NULL, so there is no need to free it at
> all.
> 
> Furthermore, it could be safer in the long term to use different labels
> for the different amounts of things that need to be freed, as done in most
> other kernel code, rather than using a single label "out".

[..]

> Date: Wed, 6 Dec 2023 16:08:49 +0800
> From: kernel test robot <lkp@...el.com>
> To: oe-kbuild@...ts.linux.dev
> Cc: lkp@...el.com, Julia Lawall <julia.lawall@...ia.fr>
> Subject: Re: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate
>     bitmap memory in backing_dev_store
> 
> BCC: lkp@...el.com
> CC: oe-kbuild-all@...ts.linux.dev
> In-Reply-To: <20231130152047.200169-1-dongyun.liu@...nssion.com>
> References: <20231130152047.200169-1-dongyun.liu@...nssion.com>
> TO: Dongyun Liu <dongyun.liu3@...il.com>
> TO: minchan@...nel.org
> TO: senozhatsky@...omium.org
> TO: axboe@...nel.dk
> CC: linux-kernel@...r.kernel.org
> CC: linux-block@...r.kernel.org
> CC: lincheng.yang@...nssion.com
> CC: jiajun.ling@...nssion.com
> CC: ldys2014@...mail.com
> CC: Dongyun Liu <dongyun.liu@...nssion.com>
> 
> Hi Dongyun,
> 
> kernel test robot noticed the following build warnings:
> 
> [auto build test WARNING on axboe-block/for-next]
> [also build test WARNING on linus/master v6.7-rc4 next-20231206]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Dongyun-Liu/zram-Using-GFP_ATOMIC-instead-of-GFP_KERNEL-to-allocate-bitmap-memory-in-backing_dev_store/20231130-233042
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
> patch link:    https://lore.kernel.org/r/20231130152047.200169-1-dongyun.liu%40transsion.com
> patch subject: [PATCH] zram: Using GFP_ATOMIC instead of GFP_KERNEL to allocate bitmap memory in backing_dev_store

This patch won't land upstream. It was NAK-ed.