linux-kernel - Re: [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field to vb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Dec 2023 12:54:44 +0300
From:   Dan Carpenter <dan.carpenter@...aro.org>
To:     Benjamin Gaignard <benjamin.gaignard@...labora.com>
Cc:     hverkuil@...all.nl, mchehab@...nel.org, tfiga@...omium.org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, kernel@...labora.com
Subject: Re: [PATCH v3 1/2] videobuf2: core: Rename min_buffers_needed field
 to vb2_queue

On Wed, Dec 06, 2023 at 09:56:07AM +0100, Benjamin Gaignard wrote:
> Rename min_buffers_needed into min_queued_buffers and update
> the documentation about it.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@...labora.com>

[ snip ]

> diff --git a/drivers/media/pci/zoran/zoran_driver.c b/drivers/media/pci/zoran/zoran_driver.c
> index fa672cc8bc67..2c91f75e8d79 100644
> --- a/drivers/media/pci/zoran/zoran_driver.c
> +++ b/drivers/media/pci/zoran/zoran_driver.c
> @@ -749,9 +749,6 @@ static int zr_vb2_queue_setup(struct vb2_queue *vq, unsigned int *nbuffers, unsi
>  
>  	zr->buf_in_reserve = 0;
>  
> -	if (*nbuffers < vq->min_buffers_needed)
> -		*nbuffers = vq->min_buffers_needed;
> -
>  	if (*nplanes) {
>  		if (sizes[0] < size)
>  			return -EINVAL;

This was not mentioned in the commit message.  And anyway, please do
that as a separate commit.

regards,
dan carpenter