linux-kernel - Re: [PATCH v2 0/2] Add HX83102j driver for HIMAX HID touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17ce60f7-81aa-452f-84cc-8b09b7cb1b7e@linaro.org>
Date:   Wed, 6 Dec 2023 12:00:41 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Allen_Lin <allencl_lin@...mail.com>, dmitry.torokhov@...il.com,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, jikos@...nel.org,
        benjamin.tissoires@...hat.com, linux-input@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] Add HX83102j driver for HIMAX HID touchscreen

On 06/12/2023 11:35, Allen_Lin wrote:
> Hi,
> This driver implements for HIMAX HID touchscreen HX8310XX series. 
> 
> Using SPI interface to acquire HID packets from driver. 
> 
> Patchs notes as below 
> 1. Add the Maintainer and devicetree bindings document for driver
> 2. Add the driver code and modify Kconfig/Makefiles to support the driver
> 
> change in v2 :
> - Fix kernel test robot build warnings.

I reviewed v1, so you must fix everything I pointed out. This code is in
absolutely terrible shape. It way over complicated, with way too many
structures, way too many abstractions (you must have exactly 0
abstractions). It was not written in Linux style.

Best regards,
Krzysztof