linux-kernel - Re: [PATCH v12 13/14] crypto: iaa - Add IAA Compression Accelerator stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 07 Dec 2023 13:59:39 -0600
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        herbert@...dor.apana.org.au, davem@...emloft.net,
        fenghua.yu@...el.com, vkoul@...nel.org
Cc:     dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, vinodh.gopal@...el.com,
        giovanni.cabiddu@...el.com, pavel@....cz,
        linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org,
        dmaengine@...r.kernel.org
Subject: Re: [PATCH v12 13/14] crypto: iaa - Add IAA Compression Accelerator
 stats

Hi Christophe,

On Thu, 2023-12-07 at 07:22 +0100, Christophe JAILLET wrote:
> Le 05/12/2023 à 22:25, Tom Zanussi a écrit :
> > Add support for optional debugfs statistics support for the IAA
> > Compression Accelerator.  This is enabled by the kernel config
> > item:
> > 
> >    CRYPTO_DEV_IAA_CRYPTO_STATS
> > 
> > When enabled, the IAA crypto driver will generate statistics which
> > can
> > be accessed at /sys/kernel/debug/iaa-crypto/.
> > 
> > See Documentation/driver-api/crypto/iax/iax-crypto.rst for details.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > ---
> 
> > +void update_max_adecomp_delay_ns(u64 start_time_ns)
> > +{
> > +       u64 time_diff;
> > +
> > +       time_diff = ktime_get_ns() - start_time_ns;
> > +
> > +       if (time_diff > max_adecomp_delay_ns)
> > +
> 
> Nit: unneeded NL.
> 

Good eye, thanks for pointing it out.

Tom

> > +               max_adecomp_delay_ns = time_diff;
> > +}
> 
> CJ