| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 7 Dec 2023 09:21:39 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Zhi Mao <zhi.mao@...iatek.com>, mchehab@...nel.org,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc: shengnan.wang@...iatek.com, yaya.chang@...iatek.com,
10572168@...com, Project_Global_Chrome_Upstream_Group@...iatek.com,
yunkec@...omium.org, conor+dt@...nel.org, matthias.bgg@...il.com,
angelogioacchino.delregno@...labora.com,
jacopo.mondi@...asonboard.com, sakari.ailus@...ux.intel.com,
hverkuil-cisco@...all.nl, heiko@...ech.de,
jernej.skrabec@...il.com, macromorgan@...mail.com,
linus.walleij@...aro.org, laurent.pinchart@...asonboard.com,
hdegoede@...hat.com, tomi.valkeinen@...asonboard.com,
gerald.loacker@...fvision.net, andy.shevchenko@...il.com,
bingbu.cao@...el.com, dan.scally@...asonboard.com,
linux-media@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH 2/2] media: dt-bindings: media: i2c: Document GC08A3
bindings
On 07/12/2023 06:20, Zhi Mao wrote:
> Add YAML device tree binding for GC08A3 CMOS image sensor,
> and the relevant MAINTAINERS entries.
>
> Signed-off-by: Zhi Mao <zhi.mao@...iatek.com>
> ---
> .../bindings/media/i2c/galaxycore,gc08a3.yaml | 127 ++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> 2 files changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> new file mode 100644
> index 000000000000..1802ff1c8a12
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> @@ -0,0 +1,127 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2020 MediaTek Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc08a3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GalaxyCore gc08a3 1/4" 8M Pixel MIPI CSI-2 sensor
> +
> +maintainers:
> + - Zhi Mao <zhi.mao@...iatek.com>
> +
> +description:
> + The gc08a3 is a raw image sensor with an MIPI CSI-2 image data
> + interface and CCI (I2C compatible) control bus. The output format
> + is raw Bayer.
> +
> +properties:
> + compatible:
> + const: galaxycore,gc08a3
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + description:
> + External clock for the sensor.
> + maxItems: 1
Items must be defined or just drop the property. How did it even appear?
Who asked for this? Your changelog is so vague that anything can happen
with this code and you will claim "it was review fix". No, you must
explain the changes.
Go back to previous review and implement all the changes requested.
> +
> + clock-frequency:
> + description:
> + Frequency of the clock in Hz.
Drop property
> +
> + dovdd-supply: true
> +
> + avdd-supply: true
> +
> + dvdd-supply: true
> +
> + enable-gpios:
> + description: Reference to the GPIO connected to the RESETB pin. Active low.
That's not enable, but reset-gpios.
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> + description:
> + Output port node, single endpoint describing the CSI-2 transmitter.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - items:
> + - const: 1
> + - const: 2
> +
> + link-frequencies: true
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - clock-frequency
> + - dovdd-supply
> + - avdd-supply
> + - dvdd-supply
> + - enable-gpios
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor0@31 {
> + status = "okay";
Drop. Do you see it anywhere in the bindings examples?
> + compatible = "galaxycore,gc08a3";
> + reg = <0x31>;
> +
> + clocks = <&gc08a3_clk>;
> + clock-names = "xvclk";
Drop
> + clock-frequency = <24000000>;
Drop
> +
> + enable-gpios = <&pio 19 GPIO_ACTIVE_HIGH>;
> +
> + avdd-supply = <&gc08a3_avdd>;
> + dovdd-supply = <&ogc08a3_dovdd>;
> + dvdd-supply = <&gc08a3_dvdd>;
> +
> + port {
> + sensor0_out_2: endpoint {
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <336000000 207000000>;
> + remote-endpoint = <&seninf_csi_port_0_in_2>;
> + };
> + };
> + };
> +
Drop stray blank line.
> + };
> +
> +...
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index b752f8902367..1a16a94fb202 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -502,6 +502,8 @@ patternProperties:
> description: Fujitsu Ltd.
> "^fxtec,.*":
> description: FX Technology Ltd.
> + "^galaxycore,.*":
> + description: GalaxyCore Inc.
That's a duplicated patch... how many of this people are going to send?
Drop and rebase on top of previous work of people.
Best regards,
Krzysztof
Powered by blists - more mailing lists