linux-kernel - Re: [PATCH v3 3/6] irqchip: Introduce RTD1319 support using the Realtek common interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a5qkso1t.ffs@tglx>
Date:   Fri, 08 Dec 2023 16:37:34 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     James Tai <james.tai@...ltek.com>, Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        James Tai <james.tai@...ltek.com>
Cc:     linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v3 3/6] irqchip: Introduce RTD1319 support using the
 Realtek common interrupt controller driver

On Wed, Nov 29 2023 at 13:43, James Tai wrote:
> Add support for the RTD1319 platform.
>
> Reported-by: kernel test robot <lkp@...el.com>
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202311061208.hJmxGqym-lkp@intel.com/

Again: These tags are just wrong.

> +static struct platform_driver realtek_intc_rtd1319_driver = {
> +	.probe = rtd1319_intc_probe,
> +	.driver = {
> +		.name = "realtek_intc_rtd1319",
> +		.of_match_table = realtek_intc_rtd1319_dt_matches,
> +		.suppress_bind_attrs = true,
> +		.pm = &realtek_intc_rtd1319_pm_ops,
> +	},

	.probe	= rtd1319_intc_probe,
	.driver	= {
		.name			= "realtek_intc_rtd1319",
		.of_match_table		= realtek_intc_rtd1319_dt_matches,
                ....
                
Please.

> +};
> +
> +static int __init realtek_intc_rtd1319_init(void)
> +{
> +	return platform_driver_register(&realtek_intc_rtd1319_driver);
> +}
> +core_initcall(realtek_intc_rtd1319_init);

What? This can be built as a module. So how is core_initcall() in any
way correct here? module_init() perhaps?

Thanks,

        tglx