linux-kernel - Re: [PATCH v3 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e92295f-3c8b-4699-bf50-0fc2b43ddf1b@linaro.org>
Date:   Fri, 8 Dec 2023 13:19:43 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     TY_Chang[張子逸] <tychang@...ltek.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>,
        Andy Shevchenko <andy@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>
Cc:     "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: gpio: realtek: Add realtek,rtd-gpio

On 08/12/2023 10:03, TY_Chang[張子逸] wrote:

> 
> The DTS use in our platform follows this structure:
> 
> soc@0 {
>     rbus: rbus@...00000 {
> 	    ...
>         iso: syscon@...0 {
> 		    ...
>             gpio: gpio@100 {
>                 compatible = "realtek,rtd1319d-iso-gpio";
>                 reg = <0x100 0x100>,
>                       <0x000 0x0b0>;
>                 interrupt-parent = <&iso_irq_mux>;
>                 interrupts = <19>, <20>;
>                 gpio-ranges = <&pinctrl 0 0 82>;
>                 gpio-controller;
>                 #gpio-cells = <2>;
>             };
>         };
>     };
> };
> 
> The base address for the GPIO controller is 0x98007100. The second line of
> 'reg' refers to the GPIO interrupt status registers, which are distributed
> within the range of 0x98007000 to 0x980070AF. 

Ah, ok.

> Would it be advisable to fetch the
> syscon from parent node(iso: syscon@...0) to handle the GPIO interrupt status
> registers?

If these are GPIO interrupts then current description is fine.

> 
>> It is, btw, 0x0, not 0x000. The same for 0x0b0 -> 0xb0, unless you want to pad
>> to full word.
>>

Best regards,
Krzysztof