linux-kernel - Re: [PATCH v3 00/13] Add support for AD7091R-2/-4/-8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXMfFxEckIm_cFPJ@debian-BULLSEYE-live-builder-AMD64>
Date:   Fri, 8 Dec 2023 10:50:15 -0300
From:   Marcelo Schmitt <marcelo.schmitt1@...il.com>
To:     David Lechner <dlechner@...libre.com>
Cc:     Marcelo Schmitt <marcelo.schmitt@...log.com>, apw@...onical.com,
        joe@...ches.com, dwaipayanray1@...il.com, lukas.bulwahn@...il.com,
        paul.cercueil@...log.com, Michael.Hennerich@...log.com,
        lars@...afoo.de, jic23@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        dan.carpenter@...aro.org, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 00/13] Add support for AD7091R-2/-4/-8

On 12/07, David Lechner wrote:
> On Thu, Dec 7, 2023 at 12:36 PM Marcelo Schmitt
> <marcelo.schmitt@...log.com> wrote:
> >
> > From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
> >
[...]
> >
> > I see regmap's interface for reading device registers under /sys/kernel/debug/regmap/.
> > I can read all registers but can't write to any of them unless I force define
> > REGMAP_ALLOW_WRITE_DEBUGFS.
> >
> > When testing events for this driver I often write to device registers
> > to set different rising/falling thresholds. I do something like this:
> > # echo 0x17 0x100 > /sys/kernel/debug/iio/iio:device0/direct_reg_access
> >
> > I tried read/writing to files under iio:device events directory but always
> > get segmentation fault. I must be forgetting to implement something.
> > What am I missing?
> >
> 
> It looks like event callbacks (.read_event_value and friends) are
> missing from `static const struct iio_info ad7091r_info = { ... }`.
> These callbacks aren't checked for NULL, e.g. in iio_ev_value_show(),
> so that is likely where the segfault is happening.

Hi David, thank you for pointing that out.
Will implement those calls in v4.