linux-kernel - Re: [PATCH v1] i2c: cadence: Add system suspend and resume PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231209130140.m2ym5yy5rv3pwtzn@zenone.zhora.eu>
Date:   Sat, 9 Dec 2023 14:01:40 +0100
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
Cc:     Michal Simek <michal.simek@....com>,
        Ley Foon Tan <leyfoon.tan@...rfivetech.com>,
        linux-arm-kernel@...ts.infradead.org, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] i2c: cadence: Add system suspend and resume PM support

Hi Ji Sheng,

[...]

> +static int __maybe_unused cdns_i2c_resume(struct device *dev)
> +{
> +	struct cdns_i2c *xi2c = dev_get_drvdata(dev);
> +	int err;
> +
> +	err = cdns_i2c_runtime_resume(dev);
> +	if (err)
> +		return err;
> +
> +	if (pm_runtime_status_suspended(dev)) {
> +		cdns_i2c_runtime_suspend(dev);
> +		if (err)
> +			return err;

have you forgotten to assign 'err'?

Andi

> +	}