linux-kernel - Re: [PATCH v1] i2c: cadence: Add system suspend and resume PM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231209130706.1906176-1-jisheng.teoh@starfivetech.com>
Date:   Sat, 9 Dec 2023 21:07:06 +0800
From:   Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
To:     <andi.shyti@...nel.org>
CC:     <jisheng.teoh@...rfivetech.com>, <leyfoon.tan@...rfivetech.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <michal.simek@....com>
Subject: Re: [PATCH v1] i2c: cadence: Add system suspend and resume PM support

On Sat, 9 Dec 2023 14:01:40 +0100
Andi Shyti <andi.shyti@...nel.org> wrote:

> Hi Ji Sheng,
> 
> [...]
> 
> > +static int __maybe_unused cdns_i2c_resume(struct device *dev)
> > +{
> > +	struct cdns_i2c *xi2c = dev_get_drvdata(dev);
> > +	int err;
> > +
> > +	err = cdns_i2c_runtime_resume(dev);
> > +	if (err)
> > +		return err;
> > +
> > +	if (pm_runtime_status_suspended(dev)) {
> > +		cdns_i2c_runtime_suspend(dev);
> > +		if (err)
> > +			return err;  
> 
> have you forgotten to assign 'err'?
> 
> Andi
> 
> > +	}  

My bad, I will fix it in v2. Thanks Andi.