linux-kernel - Re: [PATCH] block: Set memalloc_noio to false on device_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXc9jphAnYnwPnwm@infradead.org>
Date:   Mon, 11 Dec 2023 08:49:18 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     linan666@...weicloud.com
Cc:     axboe@...nel.dk, akpm@...ux-foundation.org, ming.lei@...onical.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        yukuai3@...wei.com, yi.zhang@...wei.com, houtao1@...wei.com,
        yangerkun@...wei.com
Subject: Re: [PATCH] block: Set memalloc_noio to false on device_add_disk()
 error path

On Mon, Dec 11, 2023 at 03:53:56PM +0800, linan666@...weicloud.com wrote:
> From: Li Nan <linan122@...wei.com>
> 
> On the error path of device_add_disk(), device's memalloc_noio flag was
> set but not cleared. As the comment of pm_runtime_set_memalloc_noio(),
> "The function should be called between device_add() and device_del()".
> Clear this flag before device_del() now.

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>