linux-kernel - Re: [PATCH v1 1/2] watchdog: starfive-wdt: Add JH8100 watchdog compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231211164700.1590908-1-jisheng.teoh@starfivetech.com>
Date:   Tue, 12 Dec 2023 00:47:00 +0800
From:   Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
To:     <krzysztof.kozlowski@...aro.org>
CC:     <conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
        <jisheng.teoh@...rfivetech.com>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <leyfoon.tan@...rfivetech.com>, <linux-kernel@...r.kernel.org>,
        <linux-watchdog@...r.kernel.org>, <linux@...ck-us.net>,
        <robh+dt@...nel.org>, <samin.guo@...rfivetech.com>,
        <wim@...ux-watchdog.org>, <xingyu.wu@...rfivetech.com>
Subject: Re: [PATCH v1 1/2] watchdog: starfive-wdt: Add JH8100 watchdog compatible string

On Mon, 11 Dec 2023 11:06:42 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 09/12/2023 15:27, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible for StarFive's JH8100 watchdog.
> > JH8100 watchdog reuses JH7110 register mapping.
> > 
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
> > ---
> >  drivers/watchdog/starfive-wdt.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/watchdog/starfive-wdt.c
> > b/drivers/watchdog/starfive-wdt.c index 5f501b41faf9..31785bb373d5
> > 100644 --- a/drivers/watchdog/starfive-wdt.c
> > +++ b/drivers/watchdog/starfive-wdt.c
> > @@ -581,6 +581,7 @@ static const struct dev_pm_ops
> > starfive_wdt_pm_ops = { static const struct of_device_id
> > starfive_wdt_match[] = { { .compatible = "starfive,jh7100-wdt",
> > .data = &starfive_wdt_jh7100_variant }, { .compatible =
> > "starfive,jh7110-wdt", .data = &starfive_wdt_jh7110_variant },
> > +	{ .compatible = "starfive,jh8100-wdt", .data =
> > &starfive_wdt_jh7110_variant },  
> 
> Device is compatible, so why not expressing it in the bindings and
> dropping this change?
> 
> Best regards,
> Krzysztof
> 

Ok, will drop this change.

Thanks,
Ji Sheng