[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20231211165731.1604004-1-jisheng.teoh@starfivetech.com>
Date: Tue, 12 Dec 2023 00:57:31 +0800
From: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
To: <krzysztof.kozlowski@...aro.org>
CC: <conor+dt@...nel.org>, <devicetree@...r.kernel.org>,
<jisheng.teoh@...rfivetech.com>,
<krzysztof.kozlowski+dt@...aro.org>,
<leyfoon.tan@...rfivetech.com>, <linux-kernel@...r.kernel.org>,
<linux-watchdog@...r.kernel.org>, <linux@...ck-us.net>,
<robh+dt@...nel.org>, <samin.guo@...rfivetech.com>,
<wim@...ux-watchdog.org>, <xingyu.wu@...rfivetech.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
On Mon, 11 Dec 2023 11:06:09 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> On 09/12/2023 15:27, Ji Sheng Teoh wrote:
> > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > watchdog.
> > Since JH8100 watchdog only has 1 reset signal, update binding
> > document to support one reset for "starfive,jh8100-wdt" compatible.
> >
> > Signed-off-by: Ley Foon Tan <leyfoon.tan@...rfivetech.com>
> > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
> > ---
> > .../watchdog/starfive,jh7100-wdt.yaml | 29
> > ++++++++++++++----- 1 file changed, 21 insertions(+), 8 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > index 68f3f6fd08a6..eec182317219 100644 ---
> > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > +++
> > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > @@ -19,14 +19,12 @@ description: isn't cleared, the watchdog will
> > reset the system unless the watchdog reset is disabled. -allOf:
> > - - $ref: watchdog.yaml#
> > -
> > properties:
> > compatible:
> > enum:
> > - starfive,jh7100-wdt
> > - starfive,jh7110-wdt
> > + - starfive,jh8100-wdt
> >
> > reg:
> > maxItems: 1
> > @@ -44,11 +42,6 @@ properties:
> > - const: apb
> > - const: core
> >
> > - resets:
>
> No, keep it here with min/maxItems.
>
Ok, will change it up to use min/maxItems.
> > - items:
> > - - description: APB reset
> > - - description: Core reset
> > -
> > required:
> > - compatible
> > - reg
> > @@ -56,6 +49,26 @@ required:
> > - clock-names
> > - resets
> >
> > +allOf:
> > + - $ref: watchdog.yaml#
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - starfive,jh8100-wdt
> > + then:
> > + properties:
> > + resets:
> > + items:
> > + - description: Watchdog reset
>
> Why is it called "Watchdog"? How is it different from "Core"?
Will standardize them to use "Core" instead. Thanks.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists