linux-kernel - Re: [PATCH] power: snapshot: Optimize the error variable in the snapshot_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Dec 2023 22:10:50 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Li zeming <zeming@...china.com>
Cc:     rafael@...nel.org, len.brown@...el.com, pavel@....cz,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: snapshot: Optimize the error variable in the snapshot_write_next()

On Tue, Oct 24, 2023 at 4:05 AM Li zeming <zeming@...china.com> wrote:
>
> Assign a value when removing the definition for error, which is assigned
> before use.
>
> Signed-off-by: Li zeming <zeming@...china.com>
> ---
>  kernel/power/snapshot.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 87e9f7e2bdc05..40c141144c9a1 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -2776,7 +2776,7 @@ static void *get_buffer(struct memory_bitmap *bm, struct chain_allocator *ca)
>  int snapshot_write_next(struct snapshot_handle *handle)
>  {
>         static struct chain_allocator ca;
> -       int error = 0;
> +       int error;
>
>  next:
>         /* Check if we have already loaded the entire image */
> --

Applied as 6.8 material with rewritten subject and changelog.

Thanks!