linux-kernel - Re: [PATCH] x86: tdx: hide unused tdx_dump_mce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <044e2990b5ca28d04c7305de3d2d412071975ec1.camel@intel.com>
Date:   Wed, 13 Dec 2023 20:11:17 +0000
From:   "Huang, Kai" <kai.huang@...el.com>
To:     "kirill.shutemov@...ux.intel.com" <kirill.shutemov@...ux.intel.com>,
        "Hansen, Dave" <dave.hansen@...el.com>
CC:     "arnd@...nel.org" <arnd@...nel.org>,
        "Yao, Yuan" <yuan.yao@...el.com>,
        "x86@...nel.org" <x86@...nel.org>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "mingo@...hat.com" <mingo@...hat.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "Luck, Tony" <tony.luck@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>, "hpa@...or.com" <hpa@...or.com>,
        "Yamahata, Isaku" <isaku.yamahata@...el.com>,
        "linux-coco@...ts.linux.dev" <linux-coco@...ts.linux.dev>
Subject: Re: [PATCH] x86: tdx: hide unused tdx_dump_mce_info()

On Wed, 2023-12-13 at 15:02 +0300, Kirill A. Shutemov wrote:
> On Tue, Dec 12, 2023 at 01:42:09PM -0800, Dave Hansen wrote:
> > On 12/12/23 13:36, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@...db.de>
> > > 
> > > When TDX is enabled but MCE is not, the tdx_dump_mce_info() function
> > > fails to link:
> > 
> > Thanks for the report, Arnd.
> > 
> > The only way that TDX has to report integrity errors is an MCE.  I'm not
> > sure it even makes sense to have TDX support but not MCE support.  Maybe
> > we should just make TDX host support depend on MCE.
> 
> I agree. Silently ignore integrity errors is not good idea.
> 
> TDX module spec also supports it:
> 
> "The machine-check exception handler is expected to be implemented in the
> VMM."

I also agree.  Thanks.