linux-kernel - Re: [PATCH v2 2/3] watchdog/hpwdt: Remove redundant test.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ce74029-2bf8-4bce-9c67-aa2be277861f@roeck-us.net>
Date:   Wed, 13 Dec 2023 14:14:20 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/3] watchdog/hpwdt: Remove redundant test.

On Wed, Dec 13, 2023 at 02:53:39PM -0700, Jerry Hoemann wrote:
> ProLiants of vintage to have an iLO 5, no longer send watchdog NMI
> as an IO CHECK.  They are presented to hpwdt_pretimeout as NMI_UNKNOWN.
> The preceding if statement rejects if !mynmi irrespective of value
> of pretimeout making this if statement redundant.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/hpwdt.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index 79ed1626d8ea..d5c0aa3ef069 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -181,9 +181,6 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
>  	if (ulReason == NMI_UNKNOWN && !mynmi)
>  		return NMI_DONE;
>  
> -	if (ilo5 && !pretimeout && !mynmi)
> -		return NMI_DONE;
> -
>  	if (kdumptimeout < 0)
>  		hpwdt_stop();
>  	else if (kdumptimeout == 0)
> -- 
> 2.41.0
>