linux-kernel - Re: [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1912161e-eb33-47dd-a458-b2c6179fc647@roeck-us.net>
Date:   Wed, 13 Dec 2023 14:14:32 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerry Hoemann <jerry.hoemann@....com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] watchdog/hpwdt: Remove unused variable

On Wed, Dec 13, 2023 at 02:53:40PM -0700, Jerry Hoemann wrote:
> Remove the unused variable ilo5.
> 
> Signed-off-by: Jerry Hoemann <jerry.hoemann@....com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/hpwdt.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
> index d5c0aa3ef069..138dc8d8ca3d 100644
> --- a/drivers/watchdog/hpwdt.c
> +++ b/drivers/watchdog/hpwdt.c
> @@ -33,7 +33,6 @@
>  #define DEFAULT_MARGIN			30
>  #define PRETIMEOUT_SEC			9
>  
> -static bool ilo5;
>  static unsigned int soft_margin = DEFAULT_MARGIN;	/* in seconds */
>  static bool nowayout = WATCHDOG_NOWAYOUT;
>  static bool pretimeout = IS_ENABLED(CONFIG_HPWDT_NMI_DECODING);
> @@ -360,9 +359,6 @@ static int hpwdt_init_one(struct pci_dev *dev,
>  				pretimeout ? "on" : "off");
>  	dev_info(&dev->dev, "kdumptimeout: %d.\n", kdumptimeout);
>  
> -	if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
> -		ilo5 = true;
> -
>  	return 0;
>  
>  error_wd_register:
> -- 
> 2.41.0
>