linux-kernel - Re: [PATCH 03/13] btrfs: factor out block-mapping for RAID0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02f24444-552e-45fb-9e13-f73a3cc2cb30@wdc.com>
Date:   Wed, 13 Dec 2023 09:02:12 +0000
From:   Johannes Thumshirn <Johannes.Thumshirn@....com>
To:     "hch@...radead.org" <hch@...radead.org>
CC:     Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>,
        David Sterba <dsterba@...e.com>,
        "linux-btrfs@...r.kernel.org" <linux-btrfs@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 03/13] btrfs: factor out block-mapping for RAID0

On 13.12.23 09:51, Christoph Hellwig wrote:
>> +static void map_blocks_for_raid0(struct btrfs_chunk_map *map,
> 
> I'd skip the _for here as it is a bit redundant.

OK.

>> +				 enum btrfs_map_op op,
> 
> Looking at all the patches: shouldn't the op also go into the
> btrfs_io_geometry structure?

Would make sense yes.