[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZXqr0RFw9KsP876v@hovoldconsulting.com>
Date: Thu, 14 Dec 2023 08:16:33 +0100
From: Johan Hovold <johan@...nel.org>
To: Rob Clark <robdclark@...il.com>
Cc: linux-arm-msm@...r.kernel.org, Rob Clark <robdclark@...omium.org>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: qcom: pmic_glink: Fix boot when QRTR=m
On Wed, Dec 13, 2023 at 01:06:43PM -0800, Rob Clark wrote:
> From: Rob Clark <robdclark@...omium.org>
>
> We need to bail out before adding/removing devices, if we are going
> to -EPROBE_DEFER. Otherwise boot will get stuck forever at
> deferred_probe_initcall().
Can please you expand on why this is a problem here in the commit
message?
The aux devices appear to be tore down correctly in the probe error
paths so how exactly does that lead to deferred_probe_initcall() being
stuck? This sounds like we may have a problem elsewhere which this patch
is papering over.
Also where does the probe deferral come from in your case?
pdr_handle_alloc()?
If this is a correct fix, I'd also expect there to be a Fixes and
CC-stable tag.
Johan
Powered by blists - more mailing lists