linux-kernel - Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5bc96a31-8869-483c-9427-1f4a90263874@linaro.org>
Date:   Thu, 14 Dec 2023 08:22:59 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Om Prakash Singh <quic_omprsing@...cinc.com>
Cc:     neil.armstrong@...aro.org, konrad.dybcio@...aro.org,
        agross@...nel.org, andersson@...nel.org, conor+dt@...nel.org,
        davem@...emloft.net, devicetree@...r.kernel.org,
        herbert@...dor.apana.org.au, krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, marijn.suijten@...ainline.org,
        robh+dt@...nel.org, vkoul@...nel.org
Subject: Re: [PATCH V2 2/2] arm64: dts: qcom: sc7280: add QCrypto nodes

On 14/12/2023 06:41, Om Prakash Singh wrote:
> 
> 
> On 12/12/2023 8:32 PM, Krzysztof Kozlowski wrote:
>> On 12/12/2023 14:32, Om Prakash Singh wrote:
>>> Add the QCE and Crypto BAM DMA nodes.
>>>
>>> Signed-off-by: Om Prakash Singh <quic_omprsing@...cinc.com>
>>> ---
>>>
>>> Changes in V2:
>>>    - Update DT node sequence as per register ascending order
>>
>> Hm, I don't see it...
>>
>>>    - Fix DT node properties as per convention
>>>
>>>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 22 ++++++++++++++++++++++
>>>   1 file changed, 22 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> index 66f1eb83cca7..7b705df21f4e 100644
>>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>>> @@ -2272,6 +2272,28 @@ ipa: ipa@...0000 {
>>>   			status = "disabled";
>>>   		};
>>>   
>>> +		cryptobam: dma-controller@...4000 {
>>
>> It still looks like not correctly ordered by unit address against other
>> nodes in the file.
>>
> 
> Hi Krzysztof,
> Probably I am missing something basic here. I am trying to put entries 
> addresses that are sorted wrt their current adjacent.
> 
> And it looks fine to me.
> 
> 1c0e000 (current exist)
> 1dc4000 (newly added)
> 1dfa000	(newly added)
> 1e40000	(current exist)

Then why the diff shows:
@@ -2272,6 +2272,28 @@ ipa: ipa@...0000 {
above your changes?

Best regards,
Krzysztof