linux-kernel - Re: [PATCH 01/11] writeback: Factor out writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231215165419.GA3175@lst.de>
Date: Fri, 15 Dec 2023 17:54:19 +0100
From: Christoph Hellwig <hch@....de>
To: Jan Kara <jack@...e.cz>
Cc: Christoph Hellwig <hch@....de>, linux-mm@...ck.org,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jan Kara <jack@...e.com>, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 01/11] writeback: Factor out writeback_finish()

On Fri, Dec 15, 2023 at 02:26:39PM +0100, Jan Kara wrote:
> > +	/* internal fields used by the ->writepages implementation: */
> > +	struct folio_batch fbatch;
> > +	pgoff_t done_index;
> > +	int err;
> > +	unsigned range_whole:1;		/* entire file */
> 
> Do we really need the range_whole member here? It is trivially derived from
> range_start && range_end and used only in one place in writeback_finish().

Yes, as nothing modified range_start and range_end this should be
easily doable.