linux-kernel - Re: [PATCH 09/11] writeback: Factor writeback_iter_next() out of write_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 16 Dec 2023 05:51:29 +0100
From: Christoph Hellwig <hch@....de>
To: Brian Foster <bfoster@...hat.com>
Cc: Christoph Hellwig <hch@....de>, linux-mm@...ck.org,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jan Kara <jack@...e.com>, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 09/11] writeback: Factor writeback_iter_next() out of
 write_cache_pages()

On Fri, Dec 15, 2023 at 09:17:05AM -0500, Brian Foster wrote:
> +	while ((folio = writeback_get_next(mapping, wbc)) != NULL) {
>  		wbc->done_index = folio->index;
>  		folio_lock(folio);
>  		if (likely(should_writeback_folio(mapping, wbc, folio)))
>  			break;
>  		folio_unlock(folio);
>  	}
>  
> +	if (folio)
> +		trace_wbc_writepage(wbc, inode_to_bdi(mapping->host));
>  	return folio;

I posted a very similar transformation in reply to willy's first posting
of the series :)  I guess that's 2:1 now and I might as well go ahead
and do something like that now :)