linux-kernel - Re: [PATCH v4 01/29] selftests/resctrl: Convert perror() to ksft_perror() or ksft_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1a05246e-4468-4ca2-96f5-95c137813440@intel.com>
Date: Fri, 15 Dec 2023 09:39:24 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
	<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, "Shaopeng
 Tan" <tan.shaopeng@...fujitsu.com>, Maciej Wieczór-Retman
	<maciej.wieczor-retman@...el.com>, Fenghua Yu <fenghua.yu@...el.com>
CC: <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 01/29] selftests/resctrl: Convert perror() to
 ksft_perror() or ksft_print_msg()

Hi Ilpo,

On 12/15/2023 7:04 AM, Ilpo Järvinen wrote:
> The resctrl selftest code contains a number of perror() calls. Some of
> them come with hash character and some don't. The kselftest framework
> provides ksft_perror() that is compatible with test output formatting
> so it should be used instead of adding custom hash signs.
> 
> Some perror() calls are too far away from anything that sets error.
> For those call sites, ksft_print_msg() must be used instead.
> 
> Convert perror() to ksft_perror() or ksft_print_msg().
> 
> Other related changes:
> - Remove hash signs
> - Remove trailing stops & newlines from ksft_perror()
> - Add terminating newlines for converted ksft_print_msg()
> - Use consistent capitalization
> - Small fixes/tweaks to typos & grammar of the messages
> - Extract error printing out of PARENT_EXIT() to be able to
>   differentiate
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---

Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>

Reinette