linux-kernel - Re: [PATCH 3/3] watchdog: sbsa_gwdt: add support for Marvell ac5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 15 Dec 2023 11:12:57 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Rob Herring <robh@...nel.org>, Elad Nachman <enachman@...vell.com>
Cc: wim@...ux-watchdog.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, gregory.clement@...tlin.com,
 chris.packham@...iedtelesis.co.nz, andrew@...n.ch, fu.wei@...aro.org,
 Suravee.Suthikulpanit@....com, al.stone@...aro.org, timur@...eaurora.org,
 linux-watchdog@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cyuval@...vell.com
Subject: Re: [PATCH 3/3] watchdog: sbsa_gwdt: add support for Marvell ac5

On 12/15/23 10:01, Rob Herring wrote:
> On Thu, Dec 14, 2023 at 05:04:14PM +0200, Elad Nachman wrote:
>> From: Elad Nachman <enachman@...vell.com>
>>
>> Add support for Marvell ac5/x variant of the ARM
>> sbsa global watchdog. This watchdog deviates from
>> the standard driver by the following items:
>>
>> 1. Registers reside in secure register section.
>>     hence access is only possible via SMC calls to ATF.
>>
>> 2. There are couple more registers which reside in
>>     other register areas, which needs to be configured
>>     in order for the watchdog to properly generate
>>     reset through the SOC.
>>
>> The new Marvell compatibility string differentiates between
>> the original sbsa mode of operation and the Marvell mode of
>> operation.
>>
>> Signed-off-by: Elad Nachman <enachman@...vell.com>
>> ---
>>   drivers/watchdog/sbsa_gwdt.c | 247 ++++++++++++++++++++++++++++++++---
> 
> That's more than half the existing driver...
> 

... which makes me really unhappy and wonder if it is appropriate
to hack up the existing driver that much. it doesn't look like
Marvell ac5/x really implements SBSA. Given the large number of
device specific deviations, a separate driver may be more appropriate.

Guenter