linux-kernel - Re: [RFC nf-next v1 1/2] netfilter: bpf: support prog update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231215141712.GA17065@breakpoint.cc>
Date: Fri, 15 Dec 2023 15:17:12 +0100
From: Florian Westphal <fw@...len.de>
To: "D. Wythe" <alibuda@...ux.alibaba.com>
Cc: pablo@...filter.org, kadlec@...filter.org, fw@...len.de,
	bpf@...r.kernel.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, coreteam@...filter.org,
	netfilter-devel@...r.kernel.org, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	ast@...nel.org
Subject: Re: [RFC nf-next v1 1/2] netfilter: bpf: support prog update

D. Wythe <alibuda@...ux.alibaba.com> wrote:
>  	const struct nf_defrag_hook *defrag_hook;
> +	const struct bpf_prog __rcu *nf_prog;

Hmm, why do we need this pointer?
Can't you just re-use bpf_nf_link->link.prog?

> +	rcu_assign_pointer(nf_link->nf_prog, new_prog);
> +	old_prog = xchg(&link->prog, new_prog);

This looks redundant, I think you can remove the nf_prog
pointer again.

Rest LGTM.