| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Dec 2023 07:50:53 +0800
From: kernel test robot <lkp@...el.com>
To: Christian Brauner <brauner@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@....de>
Subject: fs/nilfs2/ioctl.c:133: warning: Function parameter or struct member
'idmap' not described in 'nilfs_fileattr_set'
Hi Christian,
FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0e389834672c723435a44818ed2cabc4dad24429
commit: 8782a9aea3ab4d697ad67d1f8ebca38a4e1c24ab fs: port ->fileattr_set() to pass mnt_idmap
date: 11 months ago
config: i386-buildonly-randconfig-003-20231218 (https://download.01.org/0day-ci/archive/20231218/202312180712.fUp3kkLH-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231218/202312180712.fUp3kkLH-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312180712.fUp3kkLH-lkp@intel.com/
All warnings (new ones prefixed by >>):
fs/nilfs2/ioctl.c:120: warning: Function parameter or struct member 'dentry' not described in 'nilfs_fileattr_get'
fs/nilfs2/ioctl.c:120: warning: Function parameter or struct member 'fa' not described in 'nilfs_fileattr_get'
>> fs/nilfs2/ioctl.c:133: warning: Function parameter or struct member 'idmap' not described in 'nilfs_fileattr_set'
fs/nilfs2/ioctl.c:133: warning: Function parameter or struct member 'dentry' not described in 'nilfs_fileattr_set'
fs/nilfs2/ioctl.c:133: warning: Function parameter or struct member 'fa' not described in 'nilfs_fileattr_set'
fs/nilfs2/ioctl.c:164: warning: Function parameter or struct member 'inode' not described in 'nilfs_ioctl_getversion'
fs/nilfs2/ioctl.c:164: warning: Function parameter or struct member 'argp' not described in 'nilfs_ioctl_getversion'
vim +133 fs/nilfs2/ioctl.c
7942b919f7321f9 Koji Sato 2009-04-06 115
d623a9420c9ae2b Vyacheslav Dubeyko 2014-01-23 116 /**
7c7c436e14b863c Miklos Szeredi 2021-04-07 117 * nilfs_fileattr_get - ioctl to support lsattr
d623a9420c9ae2b Vyacheslav Dubeyko 2014-01-23 118 */
7c7c436e14b863c Miklos Szeredi 2021-04-07 119 int nilfs_fileattr_get(struct dentry *dentry, struct fileattr *fa)
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 @120 {
7c7c436e14b863c Miklos Szeredi 2021-04-07 121 struct inode *inode = d_inode(dentry);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 122
7c7c436e14b863c Miklos Szeredi 2021-04-07 123 fileattr_fill_flags(fa, NILFS_I(inode)->i_flags & FS_FL_USER_VISIBLE);
7c7c436e14b863c Miklos Szeredi 2021-04-07 124
7c7c436e14b863c Miklos Szeredi 2021-04-07 125 return 0;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 126 }
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 127
d623a9420c9ae2b Vyacheslav Dubeyko 2014-01-23 128 /**
7c7c436e14b863c Miklos Szeredi 2021-04-07 129 * nilfs_fileattr_set - ioctl to support chattr
d623a9420c9ae2b Vyacheslav Dubeyko 2014-01-23 130 */
8782a9aea3ab4d6 Christian Brauner 2023-01-13 131 int nilfs_fileattr_set(struct mnt_idmap *idmap,
7c7c436e14b863c Miklos Szeredi 2021-04-07 132 struct dentry *dentry, struct fileattr *fa)
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 @133 {
7c7c436e14b863c Miklos Szeredi 2021-04-07 134 struct inode *inode = d_inode(dentry);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 135 struct nilfs_transaction_info ti;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 136 unsigned int flags, oldflags;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 137 int ret;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 138
7c7c436e14b863c Miklos Szeredi 2021-04-07 139 if (fileattr_has_fsx(fa))
7c7c436e14b863c Miklos Szeredi 2021-04-07 140 return -EOPNOTSUPP;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 141
7c7c436e14b863c Miklos Szeredi 2021-04-07 142 flags = nilfs_mask_flags(inode->i_mode, fa->flags);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 143
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 144 ret = nilfs_transaction_begin(inode->i_sb, &ti, 0);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 145 if (ret)
7c7c436e14b863c Miklos Szeredi 2021-04-07 146 return ret;
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 147
7c7c436e14b863c Miklos Szeredi 2021-04-07 148 oldflags = NILFS_I(inode)->i_flags & ~FS_FL_USER_MODIFIABLE;
7c7c436e14b863c Miklos Szeredi 2021-04-07 149 NILFS_I(inode)->i_flags = oldflags | (flags & FS_FL_USER_MODIFIABLE);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 150
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 151 nilfs_set_inode_flags(inode);
078cd8279e65998 Deepa Dinamani 2016-09-14 152 inode->i_ctime = current_time(inode);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 153 if (IS_SYNC(inode))
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 154 nilfs_set_transaction_flag(NILFS_TI_SYNC);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 155
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 156 nilfs_mark_inode_dirty(inode);
7c7c436e14b863c Miklos Szeredi 2021-04-07 157 return nilfs_transaction_commit(inode->i_sb);
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 158 }
cde98f0f84ccff7 Ryusuke Konishi 2011-01-20 159
:::::: The code at line 133 was first introduced by commit
:::::: cde98f0f84ccff78e87235cb7b551747d6ad00de nilfs2: implement FS_IOC_GETFLAGS/SETFLAGS/GETVERSION
:::::: TO: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
:::::: CC: Ryusuke Konishi <konishi.ryusuke@....ntt.co.jp>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists