linux-kernel - Re: [PATCH 1/1] fault-inject: Include linux/types.h by default.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a5o2opdfsfnbptrrbvillogft2uqp73w4icu3mdmmwtvoqmdr2@y2fbrc6t4aew>
Date: Mon, 18 Dec 2023 11:55:47 -0600
From: Lucas De Marchi <lucas.demarchi@...el.com>
To: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>
CC: Rodrigo Vivi <rodrigo.vivi@...el.com>, Badal Nilawar
	<badal.nilawar@...el.com>, Akinobu Mita <akinobu.mita@...il.com>, "Jason
 Gunthorpe" <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>, Qi Zheng
	<zhengqi.arch@...edance.com>, <linux-kernel@...r.kernel.org>, Andrew Morton
	<akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/1] fault-inject: Include linux/types.h by default.

+Andrew

On Wed, Aug 16, 2023 at 07:17:48PM +0530, Himal Prasad Ghimiray wrote:
>Functions should_fail_alloc_page, should_failslab, and __should_failslab
>are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
>bool and gfp_t types, which are treated as unknown when
>CONFIG_FAULT_INJECTION is disabled because the inclusion of linux/types.h
>is missing.
>
>Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")
>
>Cc: Lucas De Marchi <lucas.demarchi@...el.com>
>Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
>Cc: Badal Nilawar <badal.nilawar@...el.com>
>Cc: Akinobu Mita <akinobu.mita@...il.com>
>Cc: Jason Gunthorpe <jgg@...pe.ca>
>Cc: Jens Axboe <axboe@...nel.dk>
>Cc: Qi Zheng <zhengqi.arch@...edance.com>
>Cc: linux-kernel@...r.kernel.org
>Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>

Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>

Andrew, could we take this through our drm-xe-next branch going to
drm-next if this looks good to you?

thanks
Lucas De Marchi