linux-kernel - Re: [PATCH 1/1] fault-inject: Include linux/types.h by default.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYBNDXoVO7LB_S0d@rdvivi-mobl4>
Date: Mon, 18 Dec 2023 08:45:58 -0500
From: Rodrigo Vivi <rodrigo.vivi@...nel.org>
To: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>
Cc: Lucas De Marchi <lucas.demarchi@...el.com>,
	Rodrigo Vivi <rodrigo.vivi@...el.com>,
	Badal Nilawar <badal.nilawar@...el.com>,
	Akinobu Mita <akinobu.mita@...il.com>,
	Jason Gunthorpe <jgg@...pe.ca>, Jens Axboe <axboe@...nel.dk>,
	Qi Zheng <zhengqi.arch@...edance.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] fault-inject: Include linux/types.h by default.

On Wed, Aug 16, 2023 at 07:17:48PM +0530, Himal Prasad Ghimiray wrote:
> Functions should_fail_alloc_page, should_failslab, and __should_failslab
> are declared irrespective of CONFIG_FAULT_INJECTION. These functions use
> bool and gfp_t types, which are treated as unknown when
> CONFIG_FAULT_INJECTION is disabled because the inclusion of linux/types.h
> is missing.
> 
> Fixes: 6ff1cb355e62 ("[PATCH] fault-injection capabilities infrastructure")

gentle ping on this one. we'd like to be able to include fault-inject.c
without adding extra includes that should be taken care by the
fault-inject.h itself.

> 
> Cc: Lucas De Marchi <lucas.demarchi@...el.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@...el.com>
> Cc: Badal Nilawar <badal.nilawar@...el.com>
> Cc: Akinobu Mita <akinobu.mita@...il.com>
> Cc: Jason Gunthorpe <jgg@...pe.ca>
> Cc: Jens Axboe <axboe@...nel.dk>
> Cc: Qi Zheng <zhengqi.arch@...edance.com>
> Cc: linux-kernel@...r.kernel.org

Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Kefeng Wang <wangkefeng.wang@...wei.com>

> Signed-off-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@...el.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@...el.com>

> ---
>  include/linux/fault-inject.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/fault-inject.h b/include/linux/fault-inject.h
> index 481abf530b3c..f83ab2b6cd08 100644
> --- a/include/linux/fault-inject.h
> +++ b/include/linux/fault-inject.h
> @@ -2,9 +2,10 @@
>  #ifndef _LINUX_FAULT_INJECT_H
>  #define _LINUX_FAULT_INJECT_H
>  
> +#include <linux/types.h>
> +
>  #ifdef CONFIG_FAULT_INJECTION
>  
> -#include <linux/types.h>
>  #include <linux/debugfs.h>
>  #include <linux/configfs.h>
>  #include <linux/ratelimit.h>
> -- 
> 2.25.1
>