linux-kernel - Re: [PATCH] thermal: core: Print out thermal zone name on update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gkko7nWH2ePwEhbfXR-jAb9+f+rsfYXKBMSz04uW4rYg@mail.gmail.com>
Date: Mon, 18 Dec 2023 20:40:37 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Konrad Dybcio <konrad.dybcio@...aro.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH] thermal: core: Print out thermal zone name on
 update_temperature error

On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
> Currently, we can encounter an error like this:
>
>   thermal thermal_zone48: failed to read out thermal zone (-19)
>
> It's good to know that there's been an issue, but on some occasions
> (like the error happening in the middle of a platform crash), one may
> not be able to look up what kind of thermal zone that is.
>
> Add the TZ name to the error message in order to speed up debugging.

s/name/type/ ?  It looks like that's what you mean.

First, the tz type is not its name (because there may be multiple
zones of the same type) and it would be consistent with the first
paragraph above.

>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@...aro.org>
> ---
>  drivers/thermal/thermal_core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 2415dc50c31d..a6ccf93eb34e 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -403,8 +403,8 @@ static void update_temperature(struct thermal_zone_device *tz)
>         if (ret) {
>                 if (ret != -EAGAIN)
>                         dev_warn(&tz->device,
> -                                "failed to read out thermal zone (%d)\n",
> -                                ret);
> +                                "failed to read out thermal zone %s (%d)\n",
> +                                tz->type, ret);
>                 return;
>         }
>
>
> ---