linux-kernel - Re: [PATCH] thermal: core: Print out thermal zone name on update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1e151dcf-d4fc-4aec-9f68-c8ef372a00f2@linaro.org>
Date: Tue, 19 Dec 2023 12:48:45 +0100
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: "Rafael J. Wysocki" <rafael@...nel.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>,
 Zhang Rui <rui.zhang@...el.com>, Lukasz Luba <lukasz.luba@....com>,
 Marijn Suijten <marijn.suijten@...ainline.org>, linux-pm@...r.kernel.org,
 linux-kernel@...r.kernel.org, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Subject: Re: [PATCH] thermal: core: Print out thermal zone name on
 update_temperature error

On 18.12.2023 20:40, Rafael J. Wysocki wrote:
> On Mon, Dec 18, 2023 at 3:40 PM Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>
>> Currently, we can encounter an error like this:
>>
>>   thermal thermal_zone48: failed to read out thermal zone (-19)
>>
>> It's good to know that there's been an issue, but on some occasions
>> (like the error happening in the middle of a platform crash), one may
>> not be able to look up what kind of thermal zone that is.
>>
>> Add the TZ name to the error message in order to speed up debugging.
> 
> s/name/type/ ?  It looks like that's what you mean.
> 
> First, the tz type is not its name (because there may be multiple
> zones of the same type) and it would be consistent with the first
> paragraph above.
That's possible, I'm no expert wrt thermal :)

Would you be okay with this change, together with an amended commit
message?

Konrad