linux-kernel - Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 18 Dec 2023 16:18:29 +0530
From: Sohil Mehta <sohil.mehta@...el.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-fsdevel@...r.kernel.org>
CC: <tglx@...utronix.de>, <x86@...nel.org>, <tj@...nel.org>,
	<peterz@...radead.org>, <mathieu.desnoyers@...icios.com>,
	<paulmck@...nel.org>, <keescook@...omium.org>, <dave.hansen@...ux.intel.com>,
	<mingo@...hat.com>, <will@...nel.org>, <longman@...hat.com>,
	<boqun.feng@...il.com>, <brauner@...nel.org>
Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include

> diff --git a/arch/x86/lib/cache-smp.c b/arch/x86/lib/cache-smp.c
> index 7c48ff4ae8d1..7af743bd3b13 100644
> --- a/arch/x86/lib/cache-smp.c
> +++ b/arch/x86/lib/cache-smp.c
> @@ -1,4 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> +#include <asm/paravirt.h>
>  #include <linux/smp.h>
>  #include <linux/export.h>
>  

I believe the norm is to have the linux/ includes first, followed by the
the asm/ ones. Shouldn't this case be the same?

Sohil