linux-kernel - Re: [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 15:43:07 +0000
From: Conor Dooley <conor@...nel.org>
To: Ji Sheng Teoh <jisheng.teoh@...rfivetech.com>
Cc: krzysztof.kozlowski@...aro.org, conor+dt@...nel.org,
	devicetree@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
	leyfoon.tan@...rfivetech.com, linux-kernel@...r.kernel.org,
	linux-watchdog@...r.kernel.org, linux@...ck-us.net,
	robh+dt@...nel.org, samin.guo@...rfivetech.com,
	wim@...ux-watchdog.org, xingyu.wu@...rfivetech.com
Subject: Re: [PATCH v4 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add
 compatible for JH8100

On Mon, Dec 18, 2023 at 11:37:38PM +0800, Ji Sheng Teoh wrote:
> On Mon, 18 Dec 2023 15:41:37 +0100
> Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> > On 18/12/2023 15:27, Ji Sheng Teoh wrote:
> > >>
> > >> I have real doubts that you ever tested your entire solution with
> > >> this binding. Where is the DTS?
> > >>  
> > > 
> > > Currently, the DTS is still in internal and yet to upstream as it
> > > depends on [1].  
> > 
> > Yeah, so you send untested code which cannot work or pass tests.  If
> > you do not test your code, we need to be able to at least verify it,
> > so send your DTS. Otherwise I cannot trust that this works at all.
> >
> Will submit it with DTS once things have cleared up.
> Thanks for the comment. 

[1] is not going to applied for a while since the SoC doesn't actually
exist yet and is pre-tapeout on an FPGA. I would just send the dts patch
adding the watchdog alongside the series, or else you'll be waiting for
quite a while. Or even link to the node on github or whatever.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)