linux-kernel - Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231219160756.GSZYG/3LbgTPT30Zwc@fat_crate.local>
Date: Tue, 19 Dec 2023 17:07:56 +0100
From: Borislav Petkov <bp@...en8.de>
To: Yazen Ghannam <yazen.ghannam@....com>
Cc: Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
	avadhut.naik@....com, tony.luck@...el.com, john.allen@....com,
	william.roche@...cle.com, muralidhara.mk@....com
Subject: Re: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library

On Mon, Dec 18, 2023 at 04:53:24PM -0500, Yazen Ghannam wrote:
> Yep, good points. Thanks for your feedback!

Diff ontop in case you have to resend. Folding it locally.

Thanks Christophe.

---
diff --git a/drivers/ras/amd/atl/map.c b/drivers/ras/amd/atl/map.c
index 8145b7bb2b40..d160662f534f 100644
--- a/drivers/ras/amd/atl/map.c
+++ b/drivers/ras/amd/atl/map.c
@@ -650,7 +650,7 @@ static void dump_address_map(struct dram_addr_map *map)
 
 int get_address_map(struct addr_ctx *ctx)
 {
-	int ret = 0;
+	int ret;
 
 	ret = get_address_map_common(ctx);
 	if (ret)
diff --git a/drivers/ras/amd/atl/system.c b/drivers/ras/amd/atl/system.c
index 37ad203bb93e..3b6b5a5ddaab 100644
--- a/drivers/ras/amd/atl/system.c
+++ b/drivers/ras/amd/atl/system.c
@@ -225,8 +225,6 @@ static void get_num_maps(void)
 		df_cfg.num_coh_st_maps	= 2;
 		break;
 	case DF4:
-		df_cfg.num_coh_st_maps	= 4;
-		break;
 	case DF4p5:
 		df_cfg.num_coh_st_maps	= 4;
 		break;

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette