linux-kernel - Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df9e1899-cc09-4fef-b999-05feeb0c41fa@intel.com>
Date: Tue, 19 Dec 2023 09:34:49 +0530
From: Sohil Mehta <sohil.mehta@...el.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
CC: <linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>,
	<linux-fsdevel@...r.kernel.org>, <tglx@...utronix.de>, <x86@...nel.org>,
	<tj@...nel.org>, <peterz@...radead.org>, <mathieu.desnoyers@...icios.com>,
	<paulmck@...nel.org>, <keescook@...omium.org>, <dave.hansen@...ux.intel.com>,
	<mingo@...hat.com>, <will@...nel.org>, <longman@...hat.com>,
	<boqun.feng@...il.com>, <brauner@...nel.org>, Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 03/50] x86/lib/cache-smp.c: fix missing include

On 12/19/2023 7:36 AM, Kent Overstreet wrote:
> On Mon, Dec 18, 2023 at 04:18:29PM +0530, Sohil Mehta wrote:
>> I believe the norm is to have the linux/ includes first, followed by the
>> the asm/ ones. Shouldn't this case be the same?
> 
> I haven't seen that? I generally do the reverse, simpler includes first,
> not that I have any reason for that...

I couldn't find a kernel Documentation link handy. But, I found this
email from Boris:
https://lore.kernel.org/lkml/20190411135547.GH30080@zn.tnic/

I believe at least arch/x86 follows this for the most part. One simple
reason is to make it easier to find headers when a ton of them are
included in the same file.

Sohil