linux-kernel - Re: [PATCH v1 2/2] powerpc/debug: hook to user return notifier infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8734vyn1ky.fsf@mail.lhotse>
Date: Tue, 19 Dec 2023 17:33:33 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@...nel.org>, Luming Yu
 <luming.yu@...ngroup.cn>, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org, npiggin@...il.com,
 christophe.leroy@...roup.eu
Cc: luming.yu@...il.com, ke.zhao@...ngroup.cn, dawei.li@...ngroup.cn,
 shenghui.qu@...ngroup.cn, Luming Yu <luming.yu@...ngroup.cn>
Subject: Re: [PATCH v1 2/2] powerpc/debug: hook to user return notifier
 infrastructure

Aneesh Kumar K.V <aneesh.kumar@...nel.org> writes:
> Luming Yu <luming.yu@...ngroup.cn> writes:
>
>> Before we have powerpc to use the generic entry infrastructure,
>> the call to fire user return notifier is made temporarily in powerpc
>> entry code.
>>
>
> It is still not clear what will be registered as user return notifier.
> Can you summarize that here?

fire_user_return_notifiers() is defined in kernel/user-return-notifier.c

That's built when CONFIG_USER_RETURN_NOTIFIER=y.

That is not user selectable, it's only enabled by:

arch/x86/kvm/Kconfig:        select USER_RETURN_NOTIFIER

So it looks to me like (currently) it's always a nop and does nothing.

Which makes me wonder what the point of wiring this feature up is :)
Maybe it's needed for some other feature I don't know about?

Arguably we could just enable it because we can, and it currently does
nothing so it's unlikely to break anything. But that also makes it
impossible to test the implementation is correct, and runs the risk that
one day in the future when it does get enabled only then do we discover
it doesn't work.

cheers