linux-kernel - Re: [RESEND PATCH] powerpc/fsl: fix the schema check errors for fsl,tmu-calibration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 19 Dec 2023 17:36:11 +1100
From: Michael Ellerman <mpe@...erman.id.au>
To: David Heidelberg <david@...t.cz>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
 <conor+dt@...nel.org>, Nicholas Piggin <npiggin@...il.com>, Christophe
 Leroy <christophe.leroy@...roup.eu>, Jakub Kicinski <kuba@...nel.org>,
 Vladimir Oltean <vladimir.oltean@....com>
Cc: devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] powerpc/fsl: fix the schema check errors for
 fsl,tmu-calibration

David Heidelberg <david@...t.cz> writes:
> On 13/12/2023 06:17, Michael Ellerman wrote:
>> David Heidelberg <david@...t.cz> writes:
>>> fsl,tmu-calibration is in u32-matrix. Use matching property syntax.
>>> No functional changes. Fixes warnings as:
>>> $ make dtbs_check
>>> ...
>>> arch/arm64/boot/dts/freescale/imx8mq-librem5-r3.dt.yaml: tmu@...60000: fsl,tmu-calibration:0: Additional items are not allowed (1, 41, 2, 47, 3, 53, 4, 61, 5, 67, 6, 75, 7, 81, 8, 87, 9, 95, 10, 103, 11, 111
>> This file name doesn't match the one you're modifying?
> Hello Michael. I mentioned this as a example of same problem (I 
> originally sent more patches to fix it across DTS files)
>>
>>> , 65536, 27, 65537, 35, 65538, 43, 65539, 51, 65540, 59, 65541, 67, 65542, 75, 65543, 85, 65544, 93, 65545, 103, 65546, 112, 131072, 23, 131073, 35, 131074, 45, 131075, 55, 131076, 65, 131077, 75, 131078, 87, 13
>>> 1079, 99, 131080, 111, 196608, 21, 196609, 33, 196610, 45, 196611, 57, 196612, 69, 196613, 83, 196614, 95, 196615, 113 were unexpected)
>>>          From schema: Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml
>>> ...
>> I don't see any errors like this. I guess I'm running the tests wrong?
>
> Currently I see also no error :(

At least it's not just me :)

> If you look into 
> Documentation/devicetree/bindings/thermal/qoriq-thermal.yaml you can see 
> that
>
> `fsl,tmu-calibration` matches the change I'm introducing here, most 
> likely there is a bug in validator or syntax is not 100% correct.

OK. I'll merge the patch as "correct per documentation" and just edit
the commit message to drop the error message so as not to confuse anyone.

cheers