linux-kernel - Re: [PATCH v2 20/34] media: iris: add video hardware internal buffer count and size calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc2da776-9aed-476e-9654-8ad75496db8b@linaro.org>
Date: Tue, 19 Dec 2023 12:06:48 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Dikshita Agarwal <quic_dikshita@...cinc.com>,
 linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 stanimir.k.varbanov@...il.com, quic_vgarodia@...cinc.com, agross@...nel.org,
 andersson@...nel.org, konrad.dybcio@...aro.org, mchehab@...nel.org,
 bryan.odonoghue@...aro.org
Cc: linux-arm-msm@...r.kernel.org, quic_abhinavk@...cinc.com
Subject: Re: [PATCH v2 20/34] media: iris: add video hardware internal buffer
 count and size calculation

On 18/12/2023 11:32, Dikshita Agarwal wrote:
> drivers/media/platform/qcom/vcodec/iris/Makefile | 1 + 
> .../media/platform/qcom/vcodec/iris/iris_buffer.c | 48 ++ 
> .../media/platform/qcom/vcodec/iris/iris_common.h | 1 + 
> .../media/platform/qcom/vcodec/iris/iris_core.h | 2 + 
> .../media/platform/qcom/vcodec/iris/iris_helpers.c | 13 + 
> .../media/platform/qcom/vcodec/iris/iris_helpers.h | 4 + 
> .../platform/qcom/vcodec/iris/iris_instance.h | 2 + 
> .../media/platform/qcom/vcodec/iris/iris_vdec.c | 1 + 
> .../media/platform/qcom/vcodec/iris/vpu_common.h | 8 + 
> .../media/platform/qcom/vcodec/iris/vpu_iris3.c | 6 + 
> .../platform/qcom/vcodec/iris/vpu_iris3_buffer.c | 201 +++++ 
> .../platform/qcom/vcodec/iris/vpu_iris3_buffer.h | 845 +++++++++++++++++++++

So, unless the code you are adding effects existing upstream venus, I 
think it would be a bit easier to review if you squashed down changes 
that pertain to Iris only.

For example this patch seems to relate to Iris only, so why is it a 
progressive change within your series.

Similar comment for "add vb2 streaming and buffer ops" and other "add 
feature x" patches in this series.

If the change is contained to your own codebase, then progressive 
changes are more noise than content.

Please try to squash down changes - to reduce the number of patches and 
the total LOC being proposed here.

---
bod