linux-kernel - Re: [PATCH v2 00/34] Qualcomm video encoder and decoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50eb1dd6-f7b8-478a-8ddb-1c7d9bdbe413@linaro.org>
Date: Tue, 19 Dec 2023 12:10:57 +0000
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Dikshita Agarwal <quic_dikshita@...cinc.com>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org, stanimir.k.varbanov@...il.com,
 quic_vgarodia@...cinc.com, agross@...nel.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, mchehab@...nel.org, bryan.odonoghue@...aro.org
Cc: linux-arm-msm@...r.kernel.org, quic_abhinavk@...cinc.com
Subject: Re: [PATCH v2 00/34] Qualcomm video encoder and decoder driver

On 18/12/2023 18:38, Dmitry Baryshkov wrote:
> On 18/12/2023 13:31, Dikshita Agarwal wrote:
>> This patch series introduces support for Qualcomm new video acceleration
>> hardware architecture, used for video stream decoding/encoding. This 
>> driver
>> is based on new communication protocol between video hardware and 
>> application
>> processor.
> 
> This doesn't answer one important point, you have been asked for v1. 
> What is the actual change point between Venus and Iris? What has been 
> changed so much that it demands a separate driver. This is the main 
> question for the cover letter, which has not been answered so far.
> 
>  From what I see from you bindings, the hardware is pretty close to what 
> we see in the latest venus generations. I asssme that there was a change 
> in the vcodec inteface to the firmware and other similar changes. Could 
> you please point out, which parts of Venus driver do no longer work or 
> are not applicable for sm8550?

I'd like to hear this detail too.

Grazing on some of the patches here I saw were we adding vb2 buffer ops, 
which is already supported by venus.

Similar question on booting cores and doing a busy/wait instead of a 
rendezvous based on an IRQ.

I feel there's a version of this series that can probably unify the 
codebases but, am open to being told how that is incorrect.

---
bod