linux-kernel - Re: [PATCH 2/2] gpio: sysfs: drop tabs from local variable declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYGxwgkngL2c5KE3@smile.fi.intel.com>
Date: Tue, 19 Dec 2023 17:07:46 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Linus Walleij <linus.walleij@...aro.org>,
	Kent Gibson <warthog618@...il.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH 2/2] gpio: sysfs: drop tabs from local variable
 declarations

On Tue, Dec 19, 2023 at 03:23:23PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> 
> Older code has an annoying habit of putting tabs between the type and the
> name of the variable. This doesn't really add to readability and newer
> code doesn't do it so make the entire file consistent.

Besides similar comments as per previous patch, see below.

...

> +	struct gpiod_data *data = dev_get_drvdata(dev);
> +	struct gpio_desc *desc = data->desc;
>  	int			status = 0;
>  	unsigned int		flags = data->irq_flags;

???

...

> +	struct gpio_device *gdev;
> +	struct gpiod_data *data;
>  	unsigned long		flags;
>  	int			status;
>  	const char		*ioname = NULL;

???

-- 
With Best Regards,
Andy Shevchenko