linux-kernel - Re: [PATCH v1 2/2] mfd: intel-lpss: Introduce QUIRK_CLOCK_DIVIDER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYMEaBWwtGEyaNVL@smile.fi.intel.com>
Date: Wed, 20 Dec 2023 17:12:40 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Aleksandrs Vinarskis <alex.vinarskis@...il.com>
Cc: lee@...nel.org, linux-kernel@...r.kernel.org, hdegoede@...hat.com
Subject: Re: [PATCH v1 2/2] mfd: intel-lpss: Introduce
 QUIRK_CLOCK_DIVIDER_UNITY for XPS 9530

On Wed, Dec 20, 2023 at 08:31:48AM +0100, Aleksandrs Vinarskis wrote:
> Some devices (eg. Dell XPS 9530, 2023) due to a firmware bug have a
> misconfigured clock divider, which should've been 1:1. This introduces
> quirk which conditionally re-configures the clock divider to 1:1.

(Btw, do you use --histogram when preparing patches? Use it in v2.)

...

> +	}, {	/* Dell XPS 9530 (2023) */
> +		PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x51fb, 0x1028, 0x0beb),
> +		.driver_data = (kernel_ulong_t)&quirk_skip_clock_divider,
>  	},

Should be

	}, {	/* Dell XPS 9530 (2023) */
		PCI_DEVICE_SUB(PCI_VENDOR_ID_INTEL, 0x51fb, 0x1028, 0x0beb),
		.driver_data = QUIRK_CLOCK_DIVIDER_UNITY,
	},

...

>  #define QUIRK_IGNORE_RESOURCE_CONFLICTS BIT(0)
> +#define QUIRK_CLOCK_DIVIDER_UNITY		BIT(1)

Each quirk should be documented, see, for example,
https://elixir.bootlin.com/linux/latest/source/include/linux/gpio/consumer.h#L593

-- 
With Best Regards,
Andy Shevchenko