linux-kernel - Re: [PATCH] scsi: ufs: core: Let the sq_lock protect sq_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231220170001.GN3544@thinkpad>
Date: Wed, 20 Dec 2023 22:30:01 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Can Guo <quic_cang@...cinc.com>, adrian.hunter@...el.com,
	beanhuo@...ron.com, avri.altman@....com, junwoo80.lee@...sung.com,
	martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	Alim Akhtar <alim.akhtar@...sung.com>,
	"James E.J. Bottomley" <jejb@...ux.ibm.com>,
	Stanley Chu <stanley.chu@...iatek.com>,
	Asutosh Das <quic_asutoshd@...cinc.com>,
	Peter Wang <peter.wang@...iatek.com>,
	"Bao D. Nguyen" <quic_nguyenb@...cinc.com>,
	Arthur Simchaev <Arthur.Simchaev@....com>,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scsi: ufs: core: Let the sq_lock protect sq_tail_slot
 access

On Wed, Dec 20, 2023 at 08:35:18AM -0800, Bart Van Assche wrote:
> On 12/20/23 06:50, Manivannan Sadhasivam wrote:
> > On Mon, Dec 18, 2023 at 07:32:17AM -0800, Can Guo wrote:
> > > If access sq_tail_slot without the protection from the sq_lock, race
> > > condition can have multiple SQEs copied to duplicate SQE slot(s), which can
> > > lead to multiple incredible stability issues. Fix it by moving the *dest
> > > initialization, in ufshcd_send_command(), back under protection from the
> > > sq_lock.
> > > 
> > > Fixes: 3c85f087faec ("scsi: ufs: mcq: Use pointer arithmetic in ufshcd_send_command()")
> > 
> > Cc: stable@...r.kernel.org
> 
> Hmm ... is the "Cc: stable" tag really required if a "Fixes:" tag is present?
> 

Yes it is required as I pointed out in the other thread.

- Mani

> Bart.
> 

-- 
மணிவண்ணன் சதாசிவம்