linux-kernel - [tip: x86/boot] x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 20 Dec 2023 21:32:16 -0000
From: "tip-bot2 for Colin Ian King" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Colin Ian King <colin.i.king@...il.com>, Ingo Molnar <mingo@...nel.org>,
 x86@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip: x86/boot] x86/boot: Remove redundant initialization of the
 'delta' variable in strcmp()

The following commit has been merged into the x86/boot branch of tip:

Commit-ID:     257ca14f4d780e27a0605fd68053d2cc3178a232
Gitweb:        https://git.kernel.org/tip/257ca14f4d780e27a0605fd68053d2cc3178a232
Author:        Colin Ian King <colin.i.king@...il.com>
AuthorDate:    Tue, 19 Dec 2023 14:13:04 
Committer:     Ingo Molnar <mingo@...nel.org>
CommitterDate: Wed, 20 Dec 2023 22:23:33 +01:00

x86/boot: Remove redundant initialization of the 'delta' variable in strcmp()

The 'delta' variable is zero-initialized, but never
read before the real initialization happens.

The assignment is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@...il.com>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
Link: https://lore.kernel.org/r/20231219141304.367200-1-colin.i.king@gmail.com
---
 arch/x86/boot/string.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c
index 1c8541a..c23f3b9 100644
--- a/arch/x86/boot/string.c
+++ b/arch/x86/boot/string.c
@@ -49,7 +49,7 @@ int strcmp(const char *str1, const char *str2)
 {
 	const unsigned char *s1 = (const unsigned char *)str1;
 	const unsigned char *s2 = (const unsigned char *)str2;
-	int delta = 0;
+	int delta;
 
 	while (*s1 || *s2) {
 		delta = *s1 - *s2;