linux-kernel - Re: [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231220213629.GA1177070-robh@kernel.org>
Date: Wed, 20 Dec 2023 15:36:29 -0600
From: Rob Herring <robh@...nel.org>
To: Inochi Amaoto <inochiama@...look.com>
Cc: Conor Dooley <conor@...nel.org>, jingbao qiu <qiujingbao.dlmu@...il.com>, a.zummo@...ertech.it, alexandre.belloni@...tlin.com, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, chao.wei@...hgo.com, unicorn_wang@...look.com, paul.walmsley@...ive.com, palmer@...belt.com, aou@...s.berkeley.edu, linux-rtc@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dlan@...too.org
Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for
 Sophgo CV1800 series SoC

On Mon, Dec 18, 2023 at 11:41:52AM +0800, Inochi Amaoto wrote:
> >On Sun, Dec 17, 2023 at 09:16:39PM +0800, jingbao qiu wrote:
> >> On Sun, Dec 17, 2023 at 8:26=E2=80=AFPM Conor Dooley <conor@...nel.org> w=
> >rote:
> >> >
> >> > On Sun, Dec 17, 2023 at 07:09:50PM +0800, Jingbao Qiu wrote:
> >> >
> >> > > +  reg:
> >> > > +    items:
> >> > > +      - description: data register
> >> > > +      - description: control register
> >> >
> >> > > +    rtc@...5000{
> >> > > +      compatible =3D "sophgo,cv1800-rtc";
> >> > > +      reg =3D <0x5025000 0x1000>, <0x5026000 0x1000>;
> >> >
> >> > Why are these two regions rather than just one, given they are located
> >> > next to one another?
> >> > Are they separate on one of the other devices in this family?
> >> >
> >> > Thanks,
> >> > Conor.
> >> >
> >>=20
> >> I think there are two reasons, the first one is to distinguish
> >> different logical ,
> >> REG_ CTRL (base on 0x5025000) controls clock calibration, sleep,and other
> >> functions, RTC_ CORE (base on 0x5026000) has basic RTC functionality,
> >> The second is the maximum address used by RTC_CTRL (base on 0x5025000)
> >> is 0x0ac,which is much smaller than 0x1000. Therefore, the datasheet divi=
> >des
> >> it into two parts for introduction, and I also divide it into two
> >> parts based on this
> >> introduction.So do you suggest that I merge them together=EF=BC=9F
> >
> >If all of the cv1800 series devices have them sequentially, I would just
> >make them one region.
> >
> 
> I agree with using one region. The ctrl and core region are highly
> releated.
> 
> Moreover, I suggest using syscon to describe this region, the reboot
> device is also in this region.

Then the description of the device is incomplete. Please describe the 
whole block/device.

Rob