linux-kernel - RE: [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <70fbe20aaf334d758d87974b4acdb3fc@realtek.com>
Date: Wed, 20 Dec 2023 07:13:25 +0000
From: TY_Chang[張子逸] <tychang@...ltek.com>
To: Michael Walle <michael@...le.cc>
CC: Andy Shevchenko <andy@...nel.org>,
        Linus Walleij
	<linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring
	<robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] Add GPIO support for Realtek DHC(Digital Home Center) RTD SoCs.

Hi Michael,

>Hi,
>
>> I have looked into regmap-irq, it appears that using the default irq
>> thread_fn(regmap_irq_thread) is required. However, due to hardware
>> limitation, we need to inspect the IRQ_TYPE to determine whether to
>> manage the irq within the irq handler. I think our irq portion does
>> not perfectly fit the regmap-irq.
>> Moreover, it seems that the gpio-regmap.c file needs to be modified if
>> the GPIO driver requires debounce settings. I think the gpio-regmap
>> may not be appropriate for our driver.
>> Do you have any suggestions?
>
>Can't say anything regarding the interrupt handling but adding literally one line
>to gpio-regmap shouldn't be a reason not to use it.
>

I agree that this should not be the reason. Sorry about that.
However, the interrupt handler issue may still be the limitation for our platform.

Thanks,
Tzuyi Chang