linux-kernel - Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZYKhVlgrlvq3HbFt@hovoldconsulting.com>
Date: Wed, 20 Dec 2023 09:09:58 +0100
From: Johan Hovold <johan@...nel.org>
To: Marijn Suijten <marijn.suijten@...ainline.org>
Cc: Lee Jones <lee@...nel.org>, phone-devel@...r.kernel.org,
	Pavel Machek <pavel@....cz>,
	Bjorn Andersson <bjorn.andersson@...aro.org>,
	~postmarketos/upstreaming@...ts.sr.ht,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>,
	Konrad Dybcio <konrad.dybcio@...ainline.org>,
	Martin Botka <martin.botka@...ainline.org>,
	Jami Kettunen <jami.kettunen@...ainline.org>,
	linux-arm-msm@...r.kernel.org, linux-leds@...r.kernel.org,
	Rob Herring <robh@...nel.org>, Rob Herring <robh+dt@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stephen Boyd <swboyd@...omium.org>,
	Satya Priya <quic_c_skakit@...cinc.com>
Subject: Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and
 compatible

On Tue, Dec 19, 2023 at 11:06:08AM +0100, Marijn Suijten wrote:
> On 2023-12-19 10:33:25, Johan Hovold wrote:
> > On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote:
> > 
> > > Note that I have one more unmerged leds patch around, that hasn't been looked
> > > at either.  Would it help to send this once again, perhaps with more reviewers/
> > > testing (Johan, would you mind taking a look too)?
> > > 
> > > https://lore.kernel.org/linux-leds/20220719213034.1664056-1-marijn.suijten@somainline.org/
> > 
> > Yes, I suggest you resend that one too so that it ends up in Lee's
> > inbox.
> 
> I will rebase, test and resend it too.  Just asking if you notice any glaring
> issues with this patch, as it won't be the first time it has been resent after
> not being looked at for some time.

I haven't look at this code before and only skimmed it now, but your
patch looks correct to me.

Johan