linux-kernel - Re: [PATCH v4 2/4] KVM: s390: vsie: Fix length of facility list shadowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d57bd713-4ae8-4e74-80fc-e0048b659427@linux.ibm.com>
Date: Wed, 20 Dec 2023 11:45:00 +0100
From: Janosch Frank <frankja@...ux.ibm.com>
To: Nina Schoetterl-Glausch <nsg@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Subject: Re: [PATCH v4 2/4] KVM: s390: vsie: Fix length of facility list
 shadowed

On 12/19/23 15:08, Nina Schoetterl-Glausch wrote:
> The length of the facility list accessed when interpretively executing
> STFLE is the same as the hosts facility list (in case of format-0)
> The memory following the facility list doesn't need to be accessible.
> The current VSIE implementation accesses a fixed length that exceeds the
> guest/host facility list length and can therefore wrongly inject a
> validity intercept.
> Instead, find out the host facility list length by running STFLE and
> copy only as much as necessary when shadowing.
> 
> Acked-by: David Hildenbrand <david@...hat.com>
> Reviewed-by: Claudio Imbrenda <imbrenda@...ux.ibm.com>
> Acked-by: Heiko Carstens <hca@...ux.ibm.com>
> Signed-off-by: Nina Schoetterl-Glausch <nsg@...ux.ibm.com>

Reviewed-by: Janosch Frank <frankja@...ux.ibm.com>